Skip to content

Fix issue where scssphp/Server ALWAYS sets default timezone to UTC #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix issue where scssphp/Server ALWAYS sets default timezone to UTC #12

wants to merge 3 commits into from

Conversation

@dleffler
Copy link
Contributor

@dleffler dleffler commented Mar 1, 2023

This is a problem where the program may have already set a local timezone and a scssphp/Server object is instanciated. Also adds some phpDOC exceptions statements

@dleffler
Updates to better work with SCSSPHP v1.9.0+
7d20c29 
1. Add missing @throws to function comments
2. Adds sourcemap element to array returned by compileFile() since the sourcemap must now be saved by calling program
3. Adds current file to list of files returned by compile() and compileFile(), Issue scssphp#7
@dleffler
Merge branch 'master' of https://github.com/dleffler/server
334d2bf 
# Conflicts:
#	src/Server.php
@dleffler
Fix issue where scssphp/Server ALWAYS sets default timezone to UTC, w…
1533d28 
…hich is only needed if the server doesn't have it set

Adds some PHPDoc 'exception' statements

Makes code more PHP v8 friendly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dleffler